Change TumorColumnFormatter to support structural variant alterations (two genes) #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
commented
Feb 16, 2022
| d.map(datum => ({ | ||
| sampleId: datum.sampleId, | ||
| entrezGeneId: datum.site1EntrezGeneId, | ||
| entrezGeneId: [ |
There was a problem hiding this comment.
@inodb safe to assume they all have site1 and site2?
There was a problem hiding this comment.
Some might have only one gene (a lot of them can be outside of genes). For data import at least either site 1 or site 2 needs to be specified
2 tasks
alisman
commented
Feb 18, 2022
| d.map(datum => { | ||
| // if both are available, return both genes in an array | ||
| // otherwise, return whichever is available | ||
| const genes = |
There was a problem hiding this comment.
@inodb issue you raised is fixed here
… which have two associated genes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example patient: https://genie-private.cbioportal.org/patient/summary?studyId=nsclc_genie_bpc&caseId=GENIE-DFCI-004022
Before:
After:
Fixes cBioPortal/cbioportal#9300