-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom bins feature (rebased) #4139
Custom bins feature (rebased) #4139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very small code improvement. However, this branch needs to be merged after acceptance of PR cBioPortal/cbioportal#9198 since this branch will contain some API changes (need to run yarn updateAPI
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
960d0bf
to
fab29f5
Compare
@@ -372,6 +380,11 @@ export class StudyViewPageStore | |||
@observable numberOfVisibleColorChooserModals = 0; | |||
@observable userGroupColors: { [groupId: string]: string } = {}; | |||
|
|||
chartsBinMethod: { [chartKey: string]: BinMethodOption } = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this wouldn't be observable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamabeshouse I have refactored the use of the store for the CustomBinsModal. Now the fields are observable. You can find the changes in the last commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for making all the requested changes
@pvannierop i'm getting a 500 error when i select quartlies here: https://www.cbioportal.org/study/summary?id=msk_impact_2017 I tried this with both my latest commit and also commit from prior to the changes i made. curl 'https://www.cbioportal.org/api/clinical-data-bin-counts/fetch?dataBinMethod=STATIC' |
4834589
to
4fe2527
Compare
9bd8ef0
to
1789af1
Compare
Co-authored-by: Pim van Nierop <pim@thehyve.nl>
PR feedback Adam
PR feedback Adam
1789af1
to
9bb5bc1
Compare
Extended custom bins menu according to rfc https://docs.google.com/document/d/10za8fgTsXInjUCJltWzAW-HHRJnpLa3IAT17W8M5a9E/edit
Added Quartiles, Median split and Generate bins options, where Generate bins allows user to define bin size and min value.
Backend PR: cBioPortal/cbioportal#9198
Same as #4102 but from my own fork.