Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip orientation fixes for the mutation table #145

Merged
merged 1 commit into from
Feb 1, 2017

Conversation

onursumer
Copy link
Member

What? Why?

Fixes the mutation table column header tooltips.

Changes proposed in this pull request:
Tooltip orientation is changed to top

Checks

  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Airbnb React/JSX Style guide.
  • Make sure your commit messages end with a Signed-off-by string (this line
    can be automatically added by git if you run the git-commit command with
    the -s option)

@onursumer onursumer requested a review from alisman January 31, 2017 02:55
@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (integration@b3804ee).


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3804ee...63a4cbf. Read the comment docs.

@onursumer
Copy link
Member Author

changed orientation for hotspot and mutation type tooltips
@onursumer onursumer force-pushed the tooltip-fix branch 2 times, most recently from f77f83f to 63a4cbf Compare January 31, 2017 20:56
@onursumer onursumer changed the title Updated the orientation of the table column header tooltips Tooltip orientation fixes for the mutaiton table Jan 31, 2017
@onursumer onursumer changed the title Tooltip orientation fixes for the mutaiton table Tooltip orientation fixes for the mutation table Feb 1, 2017
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-145 February 1, 2017 15:39 Inactive
@alisman alisman merged commit 40c8bf1 into cBioPortal:integration Feb 1, 2017
@onursumer onursumer deleted the tooltip-fix branch February 3, 2017 16:57
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 19, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 20, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 23, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 24, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 25, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 26, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
alisman pushed a commit to alisman/cbioportal-frontend that referenced this pull request Jun 2, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
alisman pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 8, 2022
…yarn/handlebars-4.7.7

Bump handlebars from 4.7.6 to 4.7.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants