Styling clinical attributes at top of patient view page #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
136eebc to
cac99ac
Compare
948cff1 to
4d09b34
Compare
4d09b34 to
3a8a81b
Compare
3a8a81b to
13640ef
Compare
- Add clinicalAttributesUtil.js
- use set innerHTML to prevent having to rewrite for JSX Element list
- Add attribute selection styling of clinical attribute spans
- Add some extra syling to please the eye
13640ef to
d7d515b
Compare
onursumer
added a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
Dec 18, 2019
…panel Centering filter reset panel within the lollipop plots container
onursumer
added a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
Dec 19, 2019
…panel Centering filter reset panel within the lollipop plots container
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 11, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 16, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 18, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 19, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 20, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 23, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 24, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 25, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 26, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 27, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 27, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 27, 2022
Allow setting max height in initialization
alisman
pushed a commit
to alisman/cbioportal-frontend
that referenced
this pull request
Jun 2, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
Jun 6, 2022
Allow setting max height in initialization
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
Jun 6, 2022
Allow setting max height in initialization
alisman
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
Jun 8, 2022
Allow setting max height in initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add old clinical attributes util function to style clinical attributes at the top of page. This is being done using CSS selectors by adding the clinical attribute info to the elements. Reasoning at the time was, that replacing a CSS file is easier for other institutions to replace and less error prone.
Some data normalization is performed in these functions as well that should preferably happen in the transformation step before import. Not much effort has been made therefore to improve these functions on the frontend.