Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back two unnecessary divs to Container.render #119

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Conversation

adufilie
Copy link
Contributor

What? Why?

?

Changes proposed in this pull request:

  • a
  • b

Checks

  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Airbnb React/JSX Style guide.
  • Make sure your commit messages end with a Signed-off-by string (this line
    can be automatically added by git if you run the git-commit command with
    the -s option)

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. GifGrabber.

Notify reviewers

Read our Pull request merging
policy
. If you are part of the
cBioPortal organization, notify the approprate team (remove inappropriate):

@cBioPortal/frontend

If you are not part of the cBioPortal organization look at who worked on the
file before you. Please use git blame <filename> to determine that
and notify them here:

@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-119 December 21, 2016 19:55 Inactive
@alisman alisman merged commit 6bc3151 into master Dec 21, 2016
@adufilie adufilie deleted the adufilie-patch-2 branch January 12, 2017 19:48
onursumer added a commit to onursumer/cbioportal-frontend that referenced this pull request Dec 18, 2019
Made more props optional, improved readme
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 11, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 16, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 18, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 19, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 20, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 23, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 24, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 25, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 26, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…ered

Improvements to track sort direction dynamics
alisman pushed a commit to alisman/cbioportal-frontend that referenced this pull request Jun 2, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…ered

Improvements to track sort direction dynamics
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…ered

Improvements to track sort direction dynamics
alisman pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 8, 2022
…ered

Improvements to track sort direction dynamics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants