sandbox the new implementation of bootstrap so that it applies only w… #110
Conversation
67eee8b to
92f10c7
Compare
| @@ -139,8 +140,5 @@ | |||
| "tslint-react": "^1.0.0", | |||
| "webpack-dev-server": "^1.15.0", | |||
| "yargs": "^4.8.0" | |||
| }, | |||
| "pre-commit": [ | |||
There was a problem hiding this comment.
just driving me crazy
There was a problem hiding this comment.
we can restore it when we settle on linting rules
There was a problem hiding this comment.
I prefer to keep it in, since you can just ignore it with -n if you are certain you don't want the lint checking, seems like a pain update files afterwards, but your call.
There was a problem hiding this comment.
Nice! Looks good to me, made a few comments, but do what you think is best.
One thing, try to follow 7 rules of commit messages:
http://chris.beams.io/posts/git-commit/#seven-rules
The description of this PR should prolly be in the commit message itself.
| <script src="reactapp/js/common.bundle.js"></script> | ||
| <link href="reactapp/css/bootstrap.min.css" rel="stylesheet"></link> | ||
| <script src="reactapp/common.bundle.js"></script> | ||
| <link href="reactapp/prefixed-bootstrap.min.css" rel="stylesheet"></link> |
There was a problem hiding this comment.
Is it essential to change these paths? Might be better to keep them the same, so in the parent cBioPortal project we don't have to change anything.
| @@ -139,8 +140,5 @@ | |||
| "tslint-react": "^1.0.0", | |||
| "webpack-dev-server": "^1.15.0", | |||
| "yargs": "^4.8.0" | |||
| }, | |||
| "pre-commit": [ | |||
There was a problem hiding this comment.
I prefer to keep it in, since you can just ignore it with -n if you are certain you don't want the lint checking, seems like a pain update files afterwards, but your call.
| cssFilename: 'reactapp/css/app.css', | ||
| filename: 'reactapp/[name].app.js', | ||
| chunkFilename: 'reactapp/[name].chunk.js', | ||
| cssFilename: 'reactapp/app.css', |
There was a problem hiding this comment.
As mentioned above, maybe better to keep current directory structure to prevent having to update parent project, but again your call.
…ithin a css class context .cbioportal-frontend
…or-no-checkbox Removed checkboxes from protein impact type selector
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
Highlight fixes
What? Why?
We want to have a fresh copy of bootstrap in the context of new components we are introducing. We want to try to insulate the new markup from customizations to bootstrap in the legacy project. To solve this, we build bootstrap with a wrapper class .cbioportal-frontend so that the new bootstrap styles will only appy when that class is applied to the root of a component
Checks
can be automatically added by git if you run the
git-commitcommand withthe
-soption)