correct initial visibility of hidden bars #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using 'data_hide' option, the bars are not taken into account when computing offsets and so on but they still have 'opacity:1'.
Codecov Report
@@ Coverage Diff @@
## master #2702 +/- ##
==========================================
- Coverage 82.68% 82.66% -0.02%
==========================================
Files 59 59
Lines 4718 4720 +2
==========================================
+ Hits 3901 3902 +1
- Misses 817 818 +1
Continue to review full report at Codecov.
|
beninsocrata
pushed a commit
to socrata/c3
that referenced
this pull request
Oct 31, 2019
When using 'data_hide' option, the bars are not taken into account when computing offsets and so on but they still have 'opacity:1'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using 'data_hide' option, the bars are not taken into account when
computing offsets and so on but they still have 'opacity:1'.
There is another issue that I have no time to really dig into is that the order of targets (given to the legend) may changes when you toggle back the initially hidden series, visible with the
c3 chart interaction bar chart tooltip_grouped=true expands all bars of currently hovered categorytest.Closes #2685