[Experimental] Add support for y/y2 log scale #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2678 +/- ##
==========================================
+ Coverage 80.29% 80.47% +0.18%
==========================================
Files 59 59
Lines 4537 4595 +58
==========================================
+ Hits 3643 3698 +55
- Misses 894 897 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2678 +/- ##
==========================================
+ Coverage 81.01% 81.18% +0.17%
==========================================
Files 59 59
Lines 4640 4699 +59
==========================================
+ Hits 3759 3815 +56
- Misses 881 884 +3
Continue to review full report at Codecov.
|
kt3k
reviewed
Aug 25, 2019
kt3k
reviewed
Aug 25, 2019
kt3k
reviewed
Aug 25, 2019
It's easier to reason with 'type', 'domain' then 'range' as the domain is the 'input' of the scale whereas the range is the 'output'.
6558455 to
bdfbc2d
Compare
kt3k
approved these changes
Aug 26, 2019
beninsocrata
pushed a commit
to socrata/c3
that referenced
this pull request
Oct 31, 2019
* add 'log' support for Y axis type * add documentation for Y axis type * rename var * add API to update y Axis type * add documentation for axis.types() API * add very basic tests * correct linter issue * remove unused 'padding' variable * use same scale as yAxis when converting pixels to axis values * swap range/domain as parameter for getY It's easier to reason with 'type', 'domain' then 'range' as the domain is the 'input' of the scale whereas the range is the 'output'. * add jsdoc for getY method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I'm reintroducing this PR that I did a while ago, this is kind of experimental and will probably have shortcomings with some combinaisons (stacked charts, etc..)
But it works for simple cases and may be enough for most of people.
May be enough to closes #1360