Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Oracle upsert semantics in MLSQLJDBC #1722

Merged
merged 5 commits into from
Mar 25, 2022

Conversation

chncaesar
Copy link
Contributor

@chncaesar chncaesar commented Mar 22, 2022

What changes were proposed in this pull request?

To support Oracle upsert semantics.

  • Add OracleUpsertBuilder to generate merge into statement
  • Put some logic of MySQLUpsertBuilder.upsertStatement into a separate function to better support unit test
  • Add two unit tests in UpsertBuilderTest

How was this patch tested?

  • Unit test passed. Class: UpsertBuilderTest.scala
  • Integration test on local mode pased.
    oracle jdbc upsert test
    image

mysql jdbc upsert test
image

Oracle jdbc jar used during test

        <dependency>
            <groupId>com.oracle.database.jdbc</groupId>
            <artifactId>ojdbc8</artifactId>
            <version>21.3.0.0</version>
        </dependency>

Are there and DOC need to update?

  • Documentation will be provided in byzer-doc repo

Spark Core Compatibility

Compatible with Spark 2.4 & 3.0

Issue #1718

@chncaesar chncaesar marked this pull request as draft March 22, 2022 17:04
@chncaesar chncaesar changed the title Oracle upsert Support Oracle upsert semantics in MLSQLJDBC Mar 24, 2022
@chncaesar chncaesar marked this pull request as ready for review March 24, 2022 03:08
@chncaesar chncaesar merged commit 844f2d7 into byzer-org:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants