-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add opencv build without openblas dependencies #980
Conversation
Please remove from the patch the files found under src/gen. They get regenerated anyway. |
commit them. |
How about using an environment variable like HEADLESS so that we can run the build entering a single command like The builds are now done with GitHub Actions, so you can modify the files under |
What about using |
sorry for late. I was looking into the way to add something to |
The closest thing to that would be an "extension", such as the one defined in "platform/gpu/pom.xml", but this doesn't allow us to change the dependencies of the modules. There's just no way to do that with Maven... We could work around that by providing the "excludes" as part of the platform artifact in something like "platform/noopenblas/pom.xml" instead patching the main pom.xml file. I'm not sure that would work well, but if you would like to try it out, please do! |
Yes, I've just noticed it seems not to be able to be achieved. If I succeed with your comments such as adding Second ideal thing is to get each platforms of |
Right, it doubles the number of packages.
That's determined by the classifier name here: |
Thank you! I'll try it later. |
BTW, why do you need a version of OpenCV without OpenBLAS? Are you experiencing any issues with OpenBLAS? |
No, I don't have particular reason. I just want to reduce the artifact size. |
That will only reduce the overall size by 1/3rd. To reduce more, you'll need to disable other modules from OpenCV anyway... |
Since openblas of master branch is upgraded, I have to change patch file. Can I close this PR? |
We can rebase the branch in those cases, no need to open a new PR, but
since you've already opened one, we can close this one, yes.
|
I'd like to add an option to build OpenCV without OpenBLAS dependencies.
exclude
argument to rootcppbuild.sh
build
bash cppbuild.sh -platform windows-x86_64 -exclude openblas install opencv
mvn install -Djavacpp.platform=windows-x86_64 --projects opencv