add --rename-world and --type-section-suffix options to C generator
#805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are both useful for supporting the `wasm32-wasi-preview2` target in `wasi-libc`. - `--rename-world` lets us give the files more meaningful names than e.g. "imports.h" when generating bindings for `wasi:cli/imports` - `--type-section-suffix` lets us provide a suffix for the component type custom section name per bytecodealliance#788 Ideally, both of those options would be available for all the applicable generators, but for now I'm focused on the C generator given its use in `wasi-libc`. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Jan 4, 2024
dicej
added a commit
to dicej/wasi-libc
that referenced
this pull request
Jan 5, 2024
This includes bytecodealliance/wit-bindgen#804 (fix broken indentation in generated code) and bytecodealliance/wit-bindgen#805 (support overriding world name and adding a suffix to the component type custom section). Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
added a commit
to dicej/wasi-libc
that referenced
this pull request
Jan 11, 2024
This includes bytecodealliance/wit-bindgen#804 (fix broken indentation in generated code) and bytecodealliance/wit-bindgen#805 (support overriding world name and adding a suffix to the component type custom section). Signed-off-by: Joel Dice <joel.dice@fermyon.com>
sunfishcode
pushed a commit
to WebAssembly/wasi-libc
that referenced
this pull request
Jan 11, 2024
* add WASI Preview 2 bindings This adds C bindings generated from the `wasi:cli/imports@0.2.0-rc-2023-12-05` world, plus a makefile target to regenerate them from the WIT source files. We'll use these bindings to call Preview 2 host functions when building for the `wasm32-wasi-preview2` target. Signed-off-by: Joel Dice <joel.dice@fermyon.com> * update to pre-release of `wit-bindgen` 0.17.0 This includes bytecodealliance/wit-bindgen#804 (fix broken indentation in generated code) and bytecodealliance/wit-bindgen#805 (support overriding world name and adding a suffix to the component type custom section). Signed-off-by: Joel Dice <joel.dice@fermyon.com> * test all targets; update preview2 expected output files Signed-off-by: Joel Dice <joel.dice@fermyon.com> * build for `wasm32-wasi-threads` before testing it Signed-off-by: Joel Dice <joel.dice@fermyon.com> * move generated bindings per review feedback Since these files aren't part of cloudlibc, no reason to put them under the cloudlibc directory. Signed-off-by: Joel Dice <joel.dice@fermyon.com> * move preview2.h to wasi directory Signed-off-by: Joel Dice <joel.dice@fermyon.com> --------- Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are both useful for supporting the
wasm32-wasi-preview2target inwasi-libc.--rename-worldlets us give the files more meaningful names than e.g. "imports.h" when generating bindings forwasi:cli/imports--type-section-suffixlets us provide a suffix for the component type custom section name per Allow user to override component type custom section name (or else generate a random name) #788Ideally, both of those options would be available for all the applicable generators, but for now I'm focused on the C generator given its use in
wasi-libc.