Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up a "big stack" test, and test Winch #9636

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Nov 20, 2024

This test currently takes 50s locally in debug mode locally so optimize
it by disabling optimizations in Cranelift and additionally using the
single-pass register allocator. This drops the test time to ~3s locally.

@alexcrichton alexcrichton requested a review from a team as a code owner November 20, 2024 18:30
@alexcrichton alexcrichton requested review from pchickey and removed request for a team November 20, 2024 18:30
Copy link
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to help me understand: does this mean we lose test coverage for cranelift? if we're not losing coverage, why does this test exist?

This test currently takes 50s locally in debug mode locally so optimize
it by disabling optimizations in Cranelift and additionally using the
single-pass register allocator. This drops the test time to ~3s locally.
@alexcrichton
Copy link
Member Author

A good question! I did a bit more digging and I've now changed this to:

  • This is tested on both Winch and Cranelift now.
  • Cranelift disables egraph optimizations
  • Cranelift uses the single-pass register allocation pass

That makes the test much speedier now so it will continue to test Cranelift.

@alexcrichton alexcrichton changed the title Speed up a "big stack" test by using Winch Speed up a "big stack" test, and test Winch Nov 20, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Nov 20, 2024
@pchickey pchickey removed this pull request from the merge queue due to a manual request Nov 20, 2024
@pchickey
Copy link
Contributor

Thanks. Comment needs a fix, then its good to go

@alexcrichton
Copy link
Member Author

oops, thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Nov 20, 2024
Merged via the queue into bytecodealliance:main with commit e32292c Nov 20, 2024
40 checks passed
@alexcrichton alexcrichton deleted the optimize-test branch November 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants