Refactor the #[wasmtime_test] macro
#9627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Start tests with a blank slate of features instead of with the default set of features enables (ensures each test explicitly specifies required features) * Reuse test features from `wasmtime_wast_util` to avoid duplicating listings of features. Also shares logic for "should this compiler fail this test because of unsupported features". * Move logic in `tests/wast.rs` to apply test configuration to a `Config` to a new location that can be shared across suites. * Add a new feature for `simd` and flag tests that need it with the feature. This is done in preparation for adding a new compiler strategy of Pulley to be able to flag tests as passing for pulley or not.
abrown
approved these changes
Nov 20, 2024
crates/test-macros/src/lib.rs
Outdated
| } | ||
| }); | ||
| let ignore = if strategy.should_fail(&test_config.flags) { | ||
| quote!(#[ignore]) |
There was a problem hiding this comment.
Maybe this should be #[should_panic]? I get that this keeps the original behavior but more just wondering: if we check for panics and then it stops panicking then we know more quickly which Winch tests can be enabled.
There was a problem hiding this comment.
Good point! Works well 👍
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "fuzzing"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start tests with a blank slate of features instead of with the default set of features enables (ensures each test explicitly specifies required features)
Reuse test features from
wasmtime_wast_utilto avoid duplicating listings of features. Also shares logic for "should this compiler fail this test because of unsupported features".Move logic in
tests/wast.rsto apply test configuration to aConfigto a new location that can be shared across suites.Add a new feature for
simdand flag tests that need it with the feature.This is done in preparation for adding a new compiler strategy of Pulley to be able to flag tests as passing for pulley or not.