Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winch: Add implementation for i8x16.popcnt for x64 with AVX #10241

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Winch: Add implementation for i8x16.popcnt for x64 with AVX #10241

merged 1 commit into from
Feb 19, 2025

Conversation

jeffcharles
Copy link
Contributor

Part of #8093. Adds implementation for i8x16.popcnt.

@jeffcharles jeffcharles requested review from a team as code owners February 18, 2025 15:44
@jeffcharles jeffcharles requested review from abrown and alexcrichton and removed request for a team February 18, 2025 15:44
@github-actions github-actions bot added the winch Winch issues or pull requests label Feb 18, 2025
@github-actions GitHub Actions
Copy link

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton alexcrichton requested review from saulecabrera and removed request for alexcrichton February 18, 2025 17:41
@alexcrichton
Copy link
Member

(moving my review to @saulecabrera)

saulecabrera
saulecabrera approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks!

@saulecabrera saulecabrera added this pull request to the merge queue Feb 19, 2025
Merged via the queue into bytecodealliance:main with commit 362b0db Feb 19, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

@abrown abrown Awaiting requested review from abrown abrown is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

Assignees
No one assigned
Labels
winch Winch issues or pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffcharles @alexcrichton @saulecabrera