Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winch: Add abs SIMD instructions for x86 using AVX #10202

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Winch: Add abs SIMD instructions for x86 using AVX #10202

merged 3 commits into from
Feb 7, 2025

Conversation

jeffcharles
Copy link
Contributor

Part of #8093. Adds support for the *x*.abs instructions.

@jeffcharles jeffcharles requested review from a team as code owners February 6, 2025 22:36
@jeffcharles jeffcharles requested review from fitzgen and removed request for a team February 6, 2025 22:36
@github-actions github-actions bot added the winch Winch issues or pull requests label Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

saulecabrera
saulecabrera approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@saulecabrera saulecabrera added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@jeffcharles
Copy link
Contributor Author

Added _simd_load.wast to list of unsupported tests on x86 if AVX support isn't available. That should clear up the merge queue failure.

@saulecabrera saulecabrera added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 7, 2025
@jeffcharles
Copy link
Contributor Author

Pushed up a commit that should resolve the merge conflict

@saulecabrera saulecabrera added this pull request to the merge queue Feb 7, 2025
Merged via the queue into bytecodealliance:main with commit 48fe3bb Feb 7, 2025
39 checks passed
@jeffcharles jeffcharles deleted the winch-simd-abs branch February 7, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

Assignees
No one assigned
Labels
winch Winch issues or pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffcharles @saulecabrera