Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asm: clean up and.rs #10190

Merged
merged 3 commits into from
Feb 10, 2025
Merged

asm: clean up and.rs #10190

merged 3 commits into from
Feb 10, 2025

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Feb 5, 2025

See commit messages for details.

The reference manual is unclear about certain instructions and has
confirmed errors in several descriptions for `AND`. This change removes
the problematic rows and adds an explanatory comment.
Because the instruction mnemonic already contains the width we're
sign-extending to, we only need a suffix like `_SX<from width>`.
@abrown abrown requested a review from a team as a code owner February 5, 2025 18:09
@abrown abrown requested review from fitzgen and removed request for a team February 5, 2025 18:09
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Feb 5, 2025
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fitzgen fitzgen added this pull request to the merge queue Feb 10, 2025
Merged via the queue into bytecodealliance:main with commit 79e1b53 Feb 10, 2025
51 checks passed
@abrown abrown deleted the assembler-and branch February 10, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants