Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong externref_returns_count for WasmFuncType in the wasmtime-types crate #3749

Closed
biuld opened this issue Feb 1, 2022 · 1 comment
Closed

Wrong externref_returns_count for WasmFuncType in the wasmtime-types crate #3749

biuld opened this issue Feb 1, 2022 · 1 comment

Comments

@biuld
Copy link

biuld commented Feb 1, 2022

截屏2022-02-02 上午1 35 11

Just studying the source code and I found this. Is that externref_returns_count should be obtained from returns instead of params?
@fitzgen fitzgen closed this as completed in aa4c81a Feb 1, 2022
fitzgen added a commit that referenced this issue Feb 1, 2022
@fitzgen
Merge pull request #3750 from bytecodealliance/pch/fix_3749
491e982 
fix #3749: returns count should count the returns, not the params.
@pchickey
Copy link
Contributor

pchickey commented Feb 1, 2022

Great job spotting this bug, thanks for the report! This was a correctness issue, but we don't believe that its a security-critical bug since, internally, the only effect this could have is letting wasmtime miss an opportunity to gc.

alexcrichton pushed a commit to alexcrichton/wasmtime that referenced this issue Feb 2, 2022
@alexcrichton
fix bytecodealliance#3749: returns count should count the returns, no…
700eca7 
…t the params.
mpardesh pushed a commit to avanhatt/wasmtime that referenced this issue Mar 17, 2022
@mpardesh
fix bytecodealliance#3749: returns count should count the returns, no…
4043c26 
…t the params.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pchickey @biuld