-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upgrade
subcommand
#175
Add upgrade
subcommand
#175
Conversation
@peterhuene I think this is basically what you suggested. PTAL? 🙏 |
Oh yeah, Windows. Forgot about that. 😅 I'll fix. |
538db1e
to
1fb104b
Compare
@jeffparsons thanks for the PR! I'll review this shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really fantastic, thanks for taking this on!
I just have one minor suggestion to the message that gets printed when projects are up-to-date.
3be9deb
to
18f6d64
Compare
Installs the latest version of cargo-component and upgrade to the corresponding version of cargo-component-bindings.
18f6d64
to
5a808c5
Compare
Good call; I've applied that change and rebased. Thanks for the review! 💖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR!
Installs the latest version of cargo-component and upgrade to the corresponding version of cargo-component-bindings.
Follow-up to #167 (comment).
Before merge this needs at least:
In particular I would like to draw the reviewer's attention to:
cargo-install
and thendelegate to either the existing binary or newly installed binary (unknown to us) for the rest of the job, as originally mentioned here: Refactor bindings generation. #167 (comment).exec
cargo-install
part is currently completely untested. (Though it Works For Me™.) For now I've gated it behind#[cfg(test)]
so I can still at least have the tests delegate to a child process to exercise as much of that code path as practicable. Any better ideas?