dir: Add convenience functions for accessing UTF-8 variants #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to make use of the fs_utf8 bits in some of my code, but doing so is tricky as switching `Dir` types quickly becomes "infectious" across the codebase and forces a larger conversion all at once. Adding these these two convenience APIs on `Dir` (the non-UTF8 version) I think greatly improve the ergonomics for the common cases where I may want to *view* an existing `Dir` entries (without creating a new file descriptor) and iterate over its entries, and to conveniently open a child dir as a utf-8 version. There are more methods we could add, but these feel like a useful start to me.
|
Makes sense, thanks! |
|
This is now released in cap-std 3.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make use of the fs_utf8 bits in some of my code, but doing so is tricky as switching
Dirtypes quickly becomes "infectious" across the codebase and forces a larger conversion all at once.Adding these these two convenience APIs on
Dir(the non-UTF8 version) I think greatly improve the ergonomics for the common cases where I may want to view an existingDirentries (without creating a new file descriptor) and iterate over its entries, and to conveniently open a child dir as a utf-8 version.There are more methods we could add, but these feel like a useful start to me.