Handle gracefully fixtures that only exist for tests in TestHelper.unload_fixture

[serioushaircut]

Description

When using the test helper with fixtures that only exist under their name in tests, then unload_fixture was bailing as it tried to force load those model classes from their "original" path.

What approach

Just rescue from any StandardError (load records throws Errno::ENOENT) on load_records in the unload_fixture implementation.

What else was considered

Leaving all test frozenrecords with names that also exist in the normal path and splitting them by different path names.
That was a bit unwieldy to have so many directories names like tests which all contained the same file name.

Questions

• Is their another way to do that and not blowing up the path structure for multiple fixtures?
• Should we log maybe?
• Should I catch the Errno::ENOENT specifically?

[casperisfine]

Rather than swallow the error it should be re-raised.

Passing a wrong path shouldn't silently fail.

[serioushaircut]

That's the point: there isn't a "wrong" path.

Look, the fixture and frozen record only exists for the test, and can hence not be forcefully loaded on 'unload'

"Nothing to go back to" in that case

[casperisfine]

Ah I see. Sorry I misunderstood your PR description.

Then this should be detected as part of load and registered somewhere so unload knows not to call load_records.

Rescueing an exception like this could hide a legitimate issue.

[serioushaircut]

k, something like:
during load_fixture if the model exists under the alternate path but not under the original/configured path => store it a bit differently (or just not putting it into the @cache)?

[casperisfine]

if the model exists under the alternate path but not under the original/configured path => store it a bit differently (or just not putting it into the @cache)?

Yes. e.g. store false or some other token value you can check in unload.

[serioushaircut]

voted for putting nil into the cache and only force-loading the original backend file when the cache has a non nil value. I think that expresses the idea quite well - there isn't a basepath to go back to, so it's nil. okay?

[serioushaircut]

TIL 3.2 got rid of exists?