Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add configurable version templates #36

Merged
merged 3 commits into from
Sep 8, 2018
Merged

feature: add configurable version templates #36

merged 3 commits into from
Sep 8, 2018

Conversation

byCedric
Copy link
Owner

@byCedric byCedric commented Sep 8, 2018

Description

This fixes PR #4

@byCedric byCedric force-pushed the feature/platform-version-templates branch from b8b8d33 to 5ee2e77 Compare September 8, 2018 11:54
@codecov
Copy link

codecov bot commented Sep 8, 2018 •
edited
Loading

Codecov Report

Merging #36 into develop will decrease coverage by 0.31%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
- Coverage    95.28%   94.96%   -0.32%     
===========================================
  Files            9       10       +1     
  Lines          106      139      +33     
  Branches        16       23       +7     
===========================================
+ Hits           101      132      +31     
  Misses           5        5              
- Partials         0        2       +2
Impacted Files Coverage Δ
src/version-bumpers/version.ts 100% <100%> (ø) ⬆️
src/version-bumpers/platform-android.ts 100% <100%> (ø) ⬆️
src/version-bumpers/platform-ios.ts 100% <100%> (ø) ⬆️
src/version-bumpers/index.ts 100% <100%> (ø) ⬆️
src/expo.ts 92.85% <100%> (ø) ⬆️
src/scripts/prepare.ts 86.66% <100%> (ø) ⬆️
src/config.ts 100% <100%> (ø) ⬆️
src/version.ts 92.59% <92.59%> (ø)

@codeclimate
Copy link

codeclimate bot commented Sep 8, 2018

Code Climate has analyzed commit 2d16dad and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@byCedric byCedric merged commit 5745c9d into develop Sep 8, 2018
@byCedric byCedric deleted the feature/platform-version-templates branch September 8, 2018 13:27
byCedric pushed a commit that referenced this pull request Sep 8, 2018
release: create new version 2.1.0 [skip ci]
c3cf9a4 
# [2.1.0](2.0.0...2.1.0) (2018-09-08)

### Bug fixes

* exclude semantic release configuration from npm ([c7c212e](c7c212e))

### New features

* add configurable version templates ([#36](#36)) ([5745c9d](5745c9d))
@byCedric
Copy link
Owner Author

byCedric commented Sep 8, 2018

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@byCedric