Clear cell cache when external scrolling ends #649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fix in 9.5.0 for using the cell cache in
WindowScroller
(https://github.com/bvaughn/react-virtualized/blob/master/CHANGELOG.md#950), another bug was unveiled:Since the
Grid
when used withWindowScroller
does not emitonScroll
events when the user scrolls, the cell cache is never cleaned up because the_debounceScrollEnded
function is never called.This PR fixes that by detecting if
props.isScrolling
changed fromtrue
tofalse
, and callthis._debounceScrollEnded()
in that case.