Fix grid roles for accessbility #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuweiweiwu
approved these changes
May 17, 2021
4 tasks
|
Last publish was Dec 2022... can we get a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1199 which was said to be fixed by #1208 but the PR only addressed the issue with Tables and not Grids.
This PR fixes a default role and adds another role to each cell which allows screen readers to correctly read Grids. Without this change, screen readers don't recognize any cells within the Grid and fails to announce them (tested with Voice Over on Firefox and Chrome).
npm test) all passyarn run prettier).yarn run typecheck).