This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for the rule as it stands has a bug. The line
should be
Making that change fixes issue #146. In this PR however, I have removed the usage of the languageService. Each call to
getDocumentHighlights
triggers a function which will search for the parameter in the document tree. The change I made is based on theprefer-arrow-function
rule which keeps track of each function scope to determine if we make use of the error parameter. Based on some simple comparisons as noted on the issue we do get some performance with this change.