replace URL query string on changes to search field #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes bookmarking a lot more intuitive, since the URL will always reflect the current state of the search field. This approach works on the client-side to replace that URL, using pushState. After this, I plan to create query params for the other filters on the Incidents and Field Reports pages, then add those values to this updated URL as well. #1570
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
+ Coverage 69.96% 69.98% +0.02%
==========================================
Files 186 186
Lines 9235 9235
Branches 1492 1492
==========================================
+ Hits 6461 6463 +2
+ Misses 2661 2660 -1
+ Partials 113 112 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes bookmarking a lot more intuitive, since the URL will always reflect the current state of the search field. This approach works on the client-side to replace that URL, using pushState.
After this, I plan to create query params for the other filters on the Incidents and Field Reports pages, then add those values to this updated URL as well.
#1570