make a few frontend style tweaks #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
srabraham
commented
Jan 12, 2025
- "unttachedFieldReports" was misleading, because it included all field reports, including those attached to the current incident
- we can use const rather than var in many places
- title for "show days" is helpful to clarify it's about modification date, not creation date
- no need for an additional drawMergedReportEntries call
- split onStrikeSuccess into incident and field report versions, to get rid of the nasty "typeof ... !== 'undefined'" hack
* "unttachedFieldReports" was misleading, because it included all field reports, including those attached to the current incident * we can use const rather than var in many places * title for "show days" is helpful to clarify it's about modification date, not creation date * no need for an additional drawMergedReportEntries call * split onStrikeSuccess into incident and field report versions, to get rid of the nasty "typeof ... !== 'undefined'" hack
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
- Coverage 69.77% 69.75% -0.03%
==========================================
Files 181 181
Lines 9139 9139
Branches 1503 1503
==========================================
- Hits 6377 6375 -2
- Misses 2653 2654 +1
- Partials 109 110 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.