Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EventSource to push updates to clients #46

Closed
wsanchez opened this issue May 27, 2016 · 13 comments
Closed

Use EventSource to push updates to clients #46

wsanchez opened this issue May 27, 2016 · 13 comments
Assignees
Labels

Comments

@wsanchez
Copy link
Member

Use EventSource to push updates to clients.

@wsanchez wsanchez added this to the Burning Man 2016 milestone May 27, 2016
@wsanchez
Copy link
Member Author

wsanchez commented Aug 1, 2016

Things to potentially push updates for:

  • incidents
  • personnel
  • incident types
  • incident reports

@wsanchez wsanchez modified the milestones: Later, Burning Man 2016 Aug 3, 2016
@wsanchez
Copy link
Member Author

wsanchez commented Aug 3, 2016

No way this will get done in the next three weeks, so punting.

@wsanchez wsanchez self-assigned this Aug 13, 2016
@wsanchez wsanchez modified the milestones: Burning Man 2016, Later Aug 13, 2016
@wsanchez
Copy link
Member Author

Server now has a URI for data updates as of 22d0102

@wsanchez
Copy link
Member Author

Dispatch queue subscribes to those events: c7fbe38

This reloads the entire queue data set after any update, so one question is whether that scales OK. It does appear that DataTables only does one GET request even though multiple update events come in, so that's a great thing.

@wsanchez
Copy link
Member Author

Not done yet is having individual incident contexts update.

@wsanchez
Copy link
Member Author

@kimballa: this is on the demo server.

Try opening the dispatch queue in one window, then open an incident in another. Change the incident's state or some other data visible in the dispatch queue and it should automatically update in the queue.

@wsanchez
Copy link
Member Author

#110 for incident pages
#111 for incident types
#112 for personnel
#113 for incident reports

@wsanchez
Copy link
Member Author

Closing this bug since the main server side feature is is place.

@kimballa
Copy link

Hmm. Sorry for getting to this late; it was a busy weekend of packing.

This "sort of" works for me. Creating an incident in a new tab, I see it show up in the dispatch queue. I then changed the incident description and it didn't update (for at least 10 seconds).

I refreshed the dispatch queue and it appeared correctly. I then tried to repeat this process, and loaded another new incident tab. This new description is not present.

I do see the default sorting, and the new incident updating URL, so thanks for getting those in there.

@wsanchez
Copy link
Member Author

Well, poop. Chrome, right?

@kimballa
Copy link

da

On Tue, Aug 16, 2016 at 2:36 PM, Wilfredo Sánchez Vega <
notifications@github.com> wrote:

Well, poop. Chrome, right?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#46 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFVUFzdLb4qSJZiulT58pcrrDLv9N84ks5qgi1UgaJpZM4Iowl7
.

@wsanchez
Copy link
Member Author

OK I just pushed an update, though I don't think that should have fixed anything…

But I have Safari and Chrome open on my Mac and if I change an incident state or summary in Safari, I'm seeing the update in Chrome on both the Dispatch Queue and the open incident page (which this update added support for).

I've also tested updated coming to Safari.

Might need to debug non-Mac cases on site.

@kimballa
Copy link

Whether or not that should have fixed anything, I can no longer reproduce the failure. Looking good!

¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants