-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SSE background updates for Field Reports #1498
Comments
There are a few subtleties here that make me more nervous about implementing SSEs for Field Reports than for Incidents.
I may work on the first point above by having an IMS page automatically redirect a page to the IMS homescreen when the user is logged out. That'd end the open SSE connection. |
With #1523 in place, we're now updating the Field Reports and Field Report pages on any updates to a Field Report. Here's where we are:
Here's where I might take this next:
And this is an option, but not one I'm considering all that strongly:
|
This keeps the Incident page fully up-to-date with changes on the server to Field Reports. It does this in a selective manner, just loading the particular FR that was changed. #1498
This keeps the Incident page fully up-to-date with changes on the server to Field Reports. It does this in a selective manner, just loading the particular FR that was changed. #1498
I'm ready to call this done |
We've never actually had SSEs set up for Field Reports, as I observed here:
ranger-ims-server/src/ims/element/static/ims.js
Lines 1001 to 1007 in 1f75de5
and that's because this "if-else" doesn't have an "else if" case for FieldReport:
ranger-ims-server/src/ims/application/_eventsource.py
Lines 115 to 142 in 1f75de5
The text was updated successfully, but these errors were encountered: