Skip to content

Commit

Permalink
update CHANGELOG, remove some commented-out code
Browse files Browse the repository at this point in the history
  • Loading branch information
srabraham committed Jan 24, 2025
1 parent 6c97ace commit 1d14981
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
10 changes: 8 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Changelog

This is the changelog for ranger-ims-server. This is intended to summarize changes over time,
for example to inform the Operator team each event of any differences to expect.
This is the changelog for ranger-ims-server. This is intended to summarize changes over time. It's
probably too verbose for consumption by general users of IMS, but it might be useful for anyone
trying to follow along with IMS's progression as a system.

This file must use the [Common Changelog format](https://common-changelog.org/), with the variation
that we use months rather than version numbers. We don't include dependency version upgrades in the
Expand Down Expand Up @@ -34,10 +35,15 @@ Each month below should look like the following, using the same ordering for the
- Introduced "striking" of report entries. This allows a user to hide an outdated/inaccurate entry, such that it doesn't appear by default on the Incident or Field Report page. https://github.com/burningmantech/ranger-ims-server/issues/249
- Added help modals, toggled by pressing "?", which show keyboard shortcuts for the current page. https://github.com/burningmantech/ranger-ims-server/issues/1482
- Started publishing Field Report entity updates to the web clients (via server-sent events), and started automatically background-updating the Field Reports (table) and Field Report pages on updates. https://github.com/burningmantech/ranger-ims-server/issues/1498
- Also started background-updating the Incident page based on Field Report updates, so that the user shouldn't ever need to reload an Incident page to pick up updates from the server. https://github.com/burningmantech/ranger-ims-server/pull/1555
- Added a help link from the Incident page to documentation about the meaning of the many Incident Types. https://github.com/burningmantech/ranger-ims-server/pull/1512
- Added Subresource Integrity checks to our JavaScript dependencies, improving our security against supply chain attacks. https://github.com/burningmantech/ranger-ims-server/issues/1517
- Got rid of the "requireActive" global setting, and changed it into a "validity" property of each event permission instead. This allows us to specify which permissions should be granted all year, and which should only be available to Rangers while they are on-playa. https://github.com/burningmantech/ranger-ims-server/issues/1540

### Removed

- Dropped "\*\*"-style ACLs, which we didn't use and didn't actually work at all. https://github.com/burningmantech/ranger-ims-server/pull/1553

### Fixed

- Removed confusing messaging from login screen when a user was already logged in. https://github.com/burningmantech/ranger-ims-server/pull/1511 https://github.com/burningmantech/ranger-ims-server/issues/1508
Expand Down
5 changes: 2 additions & 3 deletions src/ims/auth/_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -344,13 +344,12 @@ def _matchACL(self, user: IMSUser | None, acl: Iterable[AccessEntry]) -> bool:
An ACL of the form "position:{group}" will match a user if the ID of
one of the groups that the user is a member of equals {group}.
"""
# This form of wildcarding was previously intended to allow access to anyone,
# Temporary explainer for removed feature:
# '**' wildcarding was previously intended to allow access to anyone,
# including the None user. This permitted non-Rangers (i.e. unauthenticated
# users) to create Field Reports at kiosks on-site. This feature hadn't been
# used for years, as of 2025, and it no longer actually works anyway, due to
# the authorization model that developed in recent years in IMS.
# if "**" in [a.expression for a in acl]:
# return True

if user is None:
return False
Expand Down

0 comments on commit 1d14981

Please sign in to comment.