[Glide 4.0.0-RC0][Lint] - Error: This method should only be accessed from tests or within private scope [VisibleForTests] Glide.tearDown();

[jaredsburrows]

Auto generated code is causing lint issues:

GlideApp.java:50: Error: This method should only be accessed from tests or within private scope [VisibleForTests]
    Glide.init(glide);
    ~~~~~~~~~~~~~~~~~
GlideApp.java:57: Error: This method should only be accessed from tests or within private scope [VisibleForTests]
    Glide.tearDown();
    ~~~~~~~~~~~~~~~~

   Explanation for issues of type "VisibleForTests":
   With the @VisibleForTesting annotation you can specify an otherwise=
   attribute which specifies the intended visibility if the method had not
   been made more widely visible for the tests.

   This check looks for accesses from production code (e.g. not tests) where
   the access would not have been allowed with the intended production
   visibility.

2 errors, 0 warnings
:lintDebug FAILED
:cleanup

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ''.
> Lint found errors in the project; aborting build.
  
  Fix the issues identified by lint, or add the following to your build script to proceed with errors:
  ...
  android {
      lintOptions {
          abortOnError false
      }
  }
  ...

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

[sjudd]

What version of android are you targeting/compiling against? I don't see this lint error. I'll add a suppression anyway, but if you give me the version info I can try to verify it actually works.

[jaredsburrows]

Compile/Target - API 25

[sjudd]

Same here, but I don't see the lint errors in the sample apps.

Out of curiosity, if you add @VisibleForTesting manually to those generated classes, do you still see the lint error?

[jaredsburrows]

Here is a trimmed down version of the the android gradle DSL. I am using com.android.tools.build:gradle:2.3.2.

android {
    compileSdkVersion 25
    buildToolsVersion "25.0.3"

    defaultConfig {
        targetSdkVersion 25
    }

    lintOptions {
        textReport true
        textOutput "stdout"
        checkAllWarnings true
        warningsAsErrors true
    }
}

[TWiStErRob]

@sjudd I don't think @VisibleForTesting is transitive; just because a method is visible for testing, it doesn't warrant it to call other methods that are visible for testing.

[jaredsburrows]

Can you just suppress all?

…

On May 31, 2017 7:51 AM, "Róbert Papp" ***@***.***> wrote: @sjudd <https://github.com/sjudd> I don't think @VisibleForTesting is transitive; just because a method is visible for testing, it doesn't warrant it to call other methods that are visible for testing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1977 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABqMSJtK4d7SzruVVWGMNixR3bmYjpvAks5r_X5SgaJpZM4Nq7oQ> .

[TWiStErRob]

@jaredsburrows I don't think that's a good idea. That may hide bugs that are uncovered by lints implemented in the future. You can always add an external suppression in lint.xml

[jaredsburrows]

I understand. Then just suppress "visiblefortesting".

…

On May 31, 2017 8:01 AM, "Róbert Papp" ***@***.***> wrote: @jaredsburrows <https://github.com/jaredsburrows> I don't think that's a good idea. That may hide bugs that are uncovered by lints implemented in the future. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1977 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABqMSMTH1B_FVS3_jHmYt3QNZGnYB3f2ks5r_YDCgaJpZM4Nq7oQ> .

[jaredsburrows]

@TWiStErRob I am suppressing this via lint now but I should not have to. This is a problem introduced by 4.0.

[TWiStErRob]

yes, 4.0 is RC, Sam's ironing the kinks out, annotation processing is quite a new component of Glide, and since RC more people seem to be using it than alpha, so there're more issues coming up.

[jaredsburrows]

@TWiStErRob Yeah. So far it's great. I am just trying to help iron out these issues by reporting issues that I am finding! You guys always answer fast and are great help!

[jaredsburrows]

@sjudd Thanks!