-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize Buildpack/0.10 #365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Describe how CNB_BUILD_CONFIG_DIR variables MUST be provided in the lifecycle execution environment and the suffixes that are allowed. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Revert changes to platform.md so that buildpack.md can be merged into appropriate branches. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Define CNB_BUILD_CONFIG_DIR buildpack behavior
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Buildpack API changes for run image extension (Dockerfiles phase 3)
Co-authored-by: Terence Lee <hone02@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Terence Lee <hone02@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Sambhav Kothari <skothari44@bloomberg.net> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Stack removal: buildpack changes
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@samj1912 could you please review this cumulative PR? |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
I did a little clumsy dance here because (somehow) buildpack/0.10 had changes to platform.md that needed to be removed to fix the merge conflict, but you can see the changes in the end were trivial:
|
Signed-off-by: Ozzy Osborne <bardweller@gmail.com>
sambhav
approved these changes
Jul 18, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Moving to draft due to some late-breaking (minor) edits |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Allow metadata for extension.toml
Buildpack spec: clarify target requirements and matching logic
Buildpack spec: rename distribution to distro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.