Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Buildpack/0.10 #365

Merged
merged 39 commits into from
Jul 31, 2023
Merged

Finalize Buildpack/0.10 #365

merged 39 commits into from
Jul 31, 2023

Conversation

natalieparellano
Copy link
Member

No description provided.

natalieparellano and others added 28 commits December 6, 2022 10:48
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Describe how CNB_BUILD_CONFIG_DIR variables MUST be provided in the
lifecycle execution environment and the suffixes that are allowed.

Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Revert changes to platform.md so that buildpack.md can be merged into
appropriate branches.

Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Define CNB_BUILD_CONFIG_DIR buildpack behavior
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Buildpack API changes for run image extension (Dockerfiles phase 3)
Co-authored-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Sambhav Kothari <skothari44@bloomberg.net>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from a team as a code owner July 13, 2023 15:32
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

@samj1912 could you please review this cumulative PR?

This reverts commit 26f60e3, reversing
changes made to e16c633.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

I did a little clumsy dance here because (somehow) buildpack/0.10 had changes to platform.md that needed to be removed to fix the merge conflict, but you can see the changes in the end were trivial:

 narellano  narellano7JGH5  W  spec  buildpack/0.10  $  git diff e16c633 --name-only
README.md
buildpack.md
platform.md
 narellano  narellano7JGH5  W  spec  buildpack/0.10  $  git diff e16c633
diff --git a/README.md b/README.md
index 48d6060..01446eb 100644
--- a/README.md
+++ b/README.md
@@ -50,6 +50,6 @@ When the specification refers to a path in the context of an OCI layer tar (e.g.
 
 These documents currently specify:
 
-- Buildpack API: `0.9`
+- Buildpack API: `0.10`
 - Distribution API: `0.3`
-- Platform API: `0.10`
+- Platform API: `0.11`
diff --git a/buildpack.md b/buildpack.md
index c253bfb..4333a1a 100644
--- a/buildpack.md
+++ b/buildpack.md
@@ -82,7 +82,7 @@ This document specifies the interface between a lifecycle program and one or mor
     - [Build Plan (TOML) `requires.version` Key](#build-plan-toml-requiresversion-key)
 
 ## Buildpack API Version
-This document specifies Buildpack API version `0.9`
+This document specifies Buildpack API version `0.10`
 
 Buildpack API versions:
  - MUST be in form `<major>.<minor>` or `<major>`, where `<major>` is equivalent to `<major>.0`
diff --git a/platform.md b/platform.md

Signed-off-by: Ozzy Osborne <bardweller@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

Moving to draft due to some late-breaking (minor) edits

@natalieparellano natalieparellano marked this pull request as draft July 24, 2023 17:13
buildpack.md Outdated Show resolved Hide resolved
buildpack.md Outdated Show resolved Hide resolved
natalieparellano and others added 5 commits July 28, 2023 10:03
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Allow metadata for extension.toml
Buildpack spec: clarify target requirements and matching logic
Buildpack spec: rename distribution to distro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants