Distribution Spec (v3) - Build Image Artifact format #266
Conversation
|
@jromero, should the current spec involve the Runtime Metadata (https://github.com/buildpacks/rfcs/blob/main/text/0096-remove-stacks-mixins.md#runtime-metadata) information? Because that information should be available at "build" time, hence it should belong with the build image, I guess! |
1ce9b77 to
df62272
Compare
|
Hi @sclevine! I have addressed your review, it'd be great if you can take a look. |
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
df62272 to
7f9b9b6
Compare
|
Resolved the merge conflict. It'd be good to have a review on this. |
Signed-off-by: Javier Romero <rjavier@vmware.com>
|
|
||
| The Build Image MUST contain the following configurations: | ||
|
|
||
| * Image Config's `config.User` field MUST be set to the user [†](README.md#operating-system-conventions)UID/[‡](README.md#operating-system-conventions)SID with a writable home directory. |
There was a problem hiding this comment.
Should this include a GID to match CNB_GROUP_ID?
There was a problem hiding this comment.
FWIW, I believe this was transposed from the platform API which I don't see having that either.
There was a problem hiding this comment.
Hm, I guess it can be optional if the primary group is the intended group.
There was a problem hiding this comment.
Additional finding: Google and Heroku builders only use user (not even uid).
Google: "User": "cnb"
Heroku: "User": "heroku"
|
|
||
| The Build Image MUST contain the following configurations: | ||
|
|
||
| * Image Config's `config.User` field MUST be set to the user [†](README.md#operating-system-conventions)UID/[‡](README.md#operating-system-conventions)SID with a writable home directory. |
There was a problem hiding this comment.
Hm, I guess it can be optional if the primary group is the intended group.
This PR consists the artifact format and the delivery mechanism for Buildpacks' Build Image.
Major changes/addition involve:
os,architecturefield.Signed-off-by: Jimil Desai jimildesai42@gmail.com