Add logging and sleep to tests #1464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joey Brown <brown.joseph@salesforce.com>
1a56dae to
3a09c6d
Compare
jabrown85
reviewed
Feb 13, 2025
|
|
||
| if err != nil { | ||
| list, _ := h.DockerCli(t).ImageList(context.TODO(), image.ListOptions{}) | ||
| fmt.Println("Error encountered running ImageInspectWithRaw. imageName: ", imageName) |
There was a problem hiding this comment.
What's the thought behind fmt here and t.Log below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a thread sleep at a spot in our unit tests were we identified some flappiness. This change will help ensure our time-sensitive tests fail less often.
Context
Here's an example of failing tests this PR addresses.