-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Analyze] Validate stack IDs #471
Comments
In addition, we should ensure that the following all match
We should also consider checking whether the layers in the cache were created for the correct stack ID. If we decided to do this:
|
@jabrown85 do we want to move this to 0.12.0? I think it'll go nicely with buildpacks/spec#206 |
That sounds good to me @natalieparellano |
I think this probably makes sense to be a separate issue. |
Q: If stack IDs are the same, can we assume that the images have the same platform & architecture? |
Blocked on #530 |
During analyze, Platform 0.7 and above will validate the build and stack image if the data is available to do so. Addresses: #471 Signed-off-by: Jesse Brown <jabrown85@gmail.com>
During analyze, Platform 0.7 and above will validate the build and stack image if the data is available to do so. Addresses: #471 Signed-off-by: Jesse Brown <jabrown85@gmail.com>
During analyze, Platform 0.7 and above will validate the build and stack image if the data is available to do so. Addresses: #471 Signed-off-by: Jesse Brown <jabrown85@gmail.com>
During analyze, Platform 0.7 and above will validate the build and stack image if the data is available to do so. Addresses: #471 Signed-off-by: Jesse Brown <jabrown85@gmail.com>
During analyze, Platform 0.7 and above will validate the build and stack image if the data is available to do so. Addresses: #471 Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Removing this from 0.12.0 milestone for the same reason as #573 (comment) |
The buildpacks spec states that
However, the lifecycle does not currently validate stack IDs (leaving this up to the platform).
The lifecycle should validate that the provided buildpacks and the provided stack can work together by validating that all buildpacks list the provided stack (or
*
, if on a buildpack API that contains https://github.com/buildpacks/rfcs/blob/main/text/0056-any-stack-buildpacks.md). The lifecycle can examineCNB_STACK_ID
to know what stack was provided.The text was updated successfully, but these errors were encountered: