Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Upgrade Bootstrap version to 5.3.3 #806

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mun2025
Copy link

@mun2025 mun2025 commented Feb 7, 2025

Summary

Upgraded bootstrap version to 5.3

Before

Screenshot 2025-02-07 at 9 53 51 AM

After

Screenshot 2025-02-07 at 9 52 33 AM

Breaking Changes

Fix header alignment after upgrade

Screenshot 2025-02-07 at 10 42 31 AM

@mun2025 mun2025 requested a review from a team as a code owner February 7, 2025 16:42
@mun2025 mun2025 force-pushed the upgrade-bootstrap-version branch from 605066d to a492a67 Compare February 7, 2025 17:21
@mun2025
Copy link
Author

mun2025 commented Feb 11, 2025

@AidanDelaney Can you please review this PR basically it's to upgrade bootstrap version

@AidanDelaney
Copy link
Member

@mun2025 Thanks a lot for this PR. I am looking through it. I'm also looking at whether we should bump the axios and jquery dependencies at the same time. So, please leave it with me for a few more days.

Please feel free to introduce yourself during our regular Community catch-ups (https://buildpacks.io/community/). We love to hear from new contributors.

Muneeb Mohammed added 3 commits February 12, 2025 09:39
Signed-off-by: Muneeb Mohammed <muneeb.mohammed@muneebm-ltmeu4b.internal.salesforce.com>
Signed-off-by: Muneeb Mohammed <muneeb.mohammed@muneebm-ltmeu4b.internal.salesforce.com>
Signed-off-by: Muneeb Mohammed <muneeb.mohammed@muneebm-ltmeu4b.internal.salesforce.com>
@mun2025 mun2025 force-pushed the upgrade-bootstrap-version branch from 2084b55 to 78b1f43 Compare February 12, 2025 15:39
@mun2025 mun2025 changed the title Fix: Upgrade Bootstrap version to 5.3 Fix: Upgrade Bootstrap version to 5.3.3 Feb 12, 2025
@mun2025 mun2025 requested a review from jjbustamante February 12, 2025 16:04
@mun2025
Copy link
Author

mun2025 commented Feb 12, 2025

@AidanDelaney Are there any open issues you want me to address. I was looking at this #698 wondering which social media platforms we would like to include. If you can give me link and icons for that I can add those :)

@mun2025
Copy link
Author

mun2025 commented Feb 14, 2025

Hello @AidanDelaney - Just a quick check to see if you think this PR can be merged? Maybe I can issue seperate PR for upgrading axios and jquery if you plan to upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants