-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge bento-design-system and storybook packages #660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future improvements once this is merged:
|
veej
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small doubt, but LGTM 👍
Also, there's a story that is generating flaky chromatic diffs :( |
@babel/preset-env (required by strorybook) conflicted with @vanilla-extract/integration (used by @vanilla-extract/vite-plugin) which would make vitest fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings Storybook back into
bento-design-system
.We currently use
storybook
as a separate package as a sort of smoke test for using@buildo/bento-design-system
from a client perspective.However, this has the major drawback of having an unconventional storybook setup which has these disadvantages:
For this reason, I think as of now the cons are much bigger than the pros, and we still achieve some of the props via some other smoke testing and/or tools like https://github.com/arethetypeswrong/arethetypeswrong.github.io