#3132175: Implement Switch #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af5ac39 to
9927d6d
Compare
veej
reviewed
Mar 2, 2022
src/Switch/Switch.css.ts
Outdated
| boxShadow: "none", | ||
| }), | ||
| { | ||
| selectors: { |
There was a problem hiding this comment.
is this required? here isDisabled is true, so we should not handle the hover.
Phyele
approved these changes
Mar 2, 2022
6a1804b to
c3c1ec9
Compare
veej
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3132175
Test Plan
tests performed
✅
Switchworks correctlyScreen.Recording.2022-03-02.at.11.53.19.mov
✅ the
<input>component has the rightaria-labelledbyattribute