#3113732: Implement Form components #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veej
commented
Feb 10, 2022
|
|
||
| export const checkboxRecipe = strictRecipe({ | ||
| base: [ | ||
| { position: "relative", zIndex: "1" }, |
There was a problem hiding this comment.
maybe not the best solution, but in this way we're rendering the checkbox square above the extendedHitArea, so that the mouse events (e.g. hover) are intercepted and we can set a proper style to the square only (e.g. borders on hover)
There was a problem hiding this comment.
ok for now, I'll double check later if we can remove this zIndex
veej
commented
Feb 10, 2022
| className={fieldContainer} | ||
| > | ||
| <VisuallyHidden> | ||
| <input {...mergeProps(inputProps, fieldProps, focusProps)} ref={ref} /> |
There was a problem hiding this comment.
focusProps are missing in hm. They're needed to make the focus ring work correctly
5173e8f to
0e4de9c
Compare
Phyele
approved these changes
Feb 10, 2022
0675835 to
9e88a17
Compare
|
|
1b83564 to
592141a
Compare
added 11 commits
February 16, 2022 13:54
8a5c19f to
d3b67f5
Compare
gabro
approved these changes
Feb 16, 2022
|
|
||
| export const checkboxRecipe = strictRecipe({ | ||
| base: [ | ||
| { position: "relative", zIndex: "1" }, |
There was a problem hiding this comment.
ok for now, I'll double check later if we can remove this zIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3113732
First PR implementing just theCheckboxFieldfor now, since there are a couple of topics that must be addressedImplemented also
RadioGroupFieldTest Plan
tests performed