#3105850: Implement Breadcrumbs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabro
requested changes
Feb 11, 2022
| labelDecoration: BentoSprinkles["textDecoration"]; | ||
| }; | ||
|
|
||
| export function createLink( |
There was a problem hiding this comment.
Comment on lines
+77
to
+79
| <Label size="large" {...itemProps} color={undefined}> | ||
| {label} | ||
| </Label> |
There was a problem hiding this comment.
Let's also backport this fix I've put up today
There was a problem hiding this comment.
Actually, I'm not sure I understand that fix. It doesn't look right to me:
There was a problem hiding this comment.
oh, understood now. It makes sense only if we use ButtonLink
2f9aaa8 to
e69e4f9
Compare
added 2 commits
February 14, 2022 17:25
e69e4f9 to
607bc0e
Compare
gabro
approved these changes
Feb 14, 2022
Phyele
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3105850
Test Plan
tests performed
See storybook / Chromatic (Link + Breadcrumb components)