Merge pull request #2697 from buildkite/core-103-artifacts-exceed-limit

core-103 break from retrying if we get a 422

agent/artifact_batch_creator.go

@@ -86,7 +86,10 @@ func (a *ArtifactBatchCreator) Create(ctx context.Context) ([]*api.Artifact, err
 			}
 
 			creation, resp, err := a.apiClient.CreateArtifacts(ctxTimeout, a.conf.JobID, batch)
-			if resp != nil && (resp.StatusCode == 401 || resp.StatusCode == 404) {
+			// the server returns a 403 code if the artifact has exceeded the service quota
+			// Break the retry on any 4xx code except for 429 Too Many Requests.
+			if resp != nil && (resp.StatusCode != 429 && resp.StatusCode >= 400 && resp.StatusCode <= 499) {
+				a.logger.Warn("Artifact creation failed with status code %d, breaking the retry loop", resp.StatusCode)
 				r.Break()
 			}
 			if err != nil {