Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test revamp #87

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Test revamp #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ac922e
Deactivate dependency dashboard
toote Oct 19, 2022
5a5ea20
Pin plugin tester to latest version
toote Oct 19, 2022
b7186b2
Small cleanup of tests
toote Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: '2'
services:
tests:
image: buildkite/plugin-tester:latest@sha256:476a1024936901889147f53d2a3d8e71e99d76404972d583825514f5608083dc
image: buildkite/plugin-tester:v3.0.1
volumes:
- ".:/plugin:ro"
3 changes: 2 additions & 1 deletion renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"extends": [
"config:base"
"config:base",
":disableDependencyDashboard"
]
}
39 changes: 27 additions & 12 deletions tests/run.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
# shellcheck disable=SC2030,SC2031
# (modifying vars in subshells is expected)

load '/usr/local/lib/bats/load.bash'
load "${BATS_PLUGIN_PATH}/load.bash"

# export AWS_STUB_DEBUG=/dev/tty
# export DOCKER_STUB_DEBUG=/dev/tty

@test "ECR login; configured account ID, configured region, configured profile" {
export BUILDKITE_PLUGIN_ECR_LOGIN=true
Expand All @@ -25,10 +26,11 @@ load '/usr/local/lib/bats/load.bash'
assert_output --partial "~~~ Authenticating with AWS ECR :ecr: :docker:"
assert_output --partial "^^^ Authenticating with AWS ECR in ap-southeast-2 for 321321321321 :ecr: :docker:"
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin) == "hunter2" ]]
assert_equal "hunter2" "$(cat /tmp/password-stdin)"

unstub aws
unstub docker
rm /tmp/password-stdin
}

@test "ECR login; configured account ID, configured region" {
Expand All @@ -49,10 +51,11 @@ load '/usr/local/lib/bats/load.bash'
assert_output --partial "~~~ Authenticating with AWS ECR :ecr: :docker:"
assert_output --partial "^^^ Authenticating with AWS ECR in ap-southeast-2 for 321321321321 :ecr: :docker:"
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin) == "hunter2" ]]
assert_equal "hunter2" "$(cat /tmp/password-stdin)"

unstub aws
unstub docker
rm /tmp/password-stdin
}

@test "ECR login; configured account ID, configured legacy registry-region" {
Expand All @@ -71,10 +74,11 @@ load '/usr/local/lib/bats/load.bash'

assert_success
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin) == "hunter2" ]]
assert_equal "hunter2" "$(cat /tmp/password-stdin)"

unstub aws
unstub docker
rm /tmp/password-stdin
}
@test "ECR login; configured account ID, AWS_DEFAULT_REGION set" {
export BUILDKITE_PLUGIN_ECR_LOGIN=true
Expand All @@ -92,10 +96,11 @@ load '/usr/local/lib/bats/load.bash'

assert_success
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin) == "hunter2" ]]
assert_equal "hunter2" "$(cat /tmp/password-stdin)"

unstub aws
unstub docker
rm /tmp/password-stdin
}
@test "ECR login; configured account ID, no region specified defaults to us-east-1" {
export BUILDKITE_PLUGIN_ECR_LOGIN=true
Expand All @@ -115,9 +120,11 @@ load '/usr/local/lib/bats/load.bash'
assert_output --partial "AWS region should be specified"
assert_output --partial "Defaulting to us-east-1"
assert_output --partial "logging in to docker"
assert_equal "hunter2" "$(cat /tmp/password-stdin)"

unstub aws
unstub docker
rm /tmp/password-stdin
}
@test "ECR login; multiple account IDs" {
export BUILDKITE_PLUGIN_ECR_LOGIN=true
Expand All @@ -138,11 +145,13 @@ load '/usr/local/lib/bats/load.bash'

assert_success
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin-0) == "sameforeachaccount" ]]
[[ $(cat /tmp/password-stdin-1) == "sameforeachaccount" ]]
assert_equal "sameforeachaccount" "$(cat /tmp/password-stdin-0)"
assert_equal "sameforeachaccount" "$(cat /tmp/password-stdin-1)"

unstub aws
unstub docker
rm /tmp/password-stdin-0
rm /tmp/password-stdin-1
}
@test "ECR login; multiple comma-separated account IDs" {
export BUILDKITE_PLUGIN_ECR_LOGIN=true
Expand All @@ -162,12 +171,15 @@ load '/usr/local/lib/bats/load.bash'

assert_success
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin-0) == "sameforeachaccount" ]]
[[ $(cat /tmp/password-stdin-1) == "sameforeachaccount" ]]
assert_equal "sameforeachaccount" "$(cat /tmp/password-stdin-0)"
assert_equal "sameforeachaccount" "$(cat /tmp/password-stdin-1)"

unstub aws
unstub docker
rm /tmp/password-stdin-0
rm /tmp/password-stdin-1
}

@test "ECR login; discovered account ID" {
export BUILDKITE_PLUGIN_ECR_LOGIN=true
export AWS_DEFAULT_REGION=us-east-1
Expand All @@ -184,10 +196,11 @@ load '/usr/local/lib/bats/load.bash'

assert_success
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin) == "hunter2" ]]
assert_equal "hunter2" "$(cat /tmp/password-stdin)"

unstub aws
unstub docker
rm /tmp/password-stdin
}

@test "ECR login; discovered account ID, with error, and then retry until success" {
Expand All @@ -210,10 +223,11 @@ load '/usr/local/lib/bats/load.bash'
assert_success
assert_output --partial "Login failed on attempt 1 of 2. Trying again in 1 seconds.."
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin) == "hunter2" ]]
assert_equal "hunter2" "$(cat /tmp/password-stdin)"

unstub aws
unstub docker
rm /tmp/password-stdin
}

@test "ECR login; discovered account ID, with error in docker login, and then retry until success" {
Expand All @@ -236,10 +250,11 @@ load '/usr/local/lib/bats/load.bash'
assert_success
assert_output --partial "Login failed on attempt 1 of 2. Trying again in 1 seconds.."
assert_output --partial "logging in to docker"
[[ $(cat /tmp/password-stdin) == "hunter2" ]]
assert_equal "hunter2" "$(cat /tmp/password-stdin)"

unstub aws
unstub docker
rm /tmp/password-stdin
}

@test "ECR login; discovered account ID, with error, and then retry until failure" {
Expand Down