Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default Buildkit output mode to plain #281

Closed
wants to merge 1 commit into from

Conversation

toolmantim
Copy link
Contributor

As mentioned in #256, if you use Buildkit the default output can create a bunch of erroneous log output groups.

This change sets the default Buildkit output to plain to avoid this.

Fixes #256

@toolmantim toolmantim requested a review from jayco July 15, 2020 07:03
@toolmantim
Copy link
Contributor Author

One thing I didn't consider, is that people still need to set DOCKER_BUILDKIT=1 environment variable?

Which means, either:

  1. We could just add a buildkit: true option to the plugin, which sets both of the environment variables for them
  2. We could leave it as-is, but only set BUILDKIT_PROGRESS conditionally if DOCKER_BUILKIT == "1"

I think I'd prefer version 1. What do you think @jayco & @niceking?

@niceking
Copy link

Hey @toolmantim! Totally keen to pair on this!!

@niceking
Copy link

One thing I didn't consider, is that people still need to set DOCKER_BUILDKIT=1 environment variable?

Which means, either:

  1. We could just add a buildkit: true option to the plugin, which sets both of the environment variables for them
  2. We could leave it as-is, but only set BUILDKIT_PROGRESS conditionally if DOCKER_BUILKIT == "1"

I think I'd prefer version 1. What do you think @jayco & @niceking?

I prefer 1 too! Nicer to be explicit rather than doing sneaky we-assumed-this-because-you-did-this things that we may forget about later!

@toolmantim
Copy link
Contributor Author

Another thing to note, is that it turns out there's a little more to this than we thought — there's also parts of the output that we'll need to modify if buildkit is set to true, it's not just about setting the output mode to plain.

@toolmantim
Copy link
Contributor Author

Turns out this doesn't actually solve the problem people were having after all, so let's close this for now.

@toolmantim toolmantim closed this Sep 15, 2020
@toolmantim toolmantim deleted the set-buildkit-output-to-plain branch September 15, 2020 03:36
@henare henare mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Buildkit?
2 participants