-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows port of bb_runner and bb_worker #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to seeing this land!
Should be good for another round of review. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking perfect. Thanks for your perseverance!
I've re-enabled CI again. It may be the case it complains about some missing docstrings on newly added public APIs? If so, could you address those? Will merge this change once CI is happy.
Done. |
This change intends to port bb_runner and bb_worker to Windows and is part of #7. Please review this in conjuncion with buildbarn/bb-storage#129.
Key changes include:
go_dependencies()
beforego_rules_dependencies()
for the same reason detailed in Windows port fixes and improvements bb-storage#129.local_runner
and, because it shares a lot of code with the unix runner, I refactored the code to have the two share a commonlocal_runner.go
.bazel-differentiate-workspace-cache
when executing. The property is added as a hack for CPP builds on Windows. It is a hack to differentiate the hash keys depending on the workspace and is not intended to mean much to the remote executor: Remote: Use execRoot as input root and do NOT set working directory by default. bazelbuild/bazel#13339I will create a draft PR first and, if and when buildbarn/bb-storage#129 looks good and can be merged, I will update the dependency here.
Cheers,
mh
Disclaimer: