Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows port of bb_runner and bb_worker #90

Merged
merged 4 commits into from
Oct 29, 2021

Conversation

mou-hao
Copy link
Contributor

@mou-hao mou-hao commented Oct 25, 2021

This change intends to port bb_runner and bb_worker to Windows and is part of #7. Please review this in conjuncion with buildbarn/bb-storage#129.

Key changes include:

I will create a draft PR first and, if and when buildbarn/bb-storage#129 looks good and can be merged, I will update the dependency here.

Cheers,
mh

Disclaimer:

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE APACHE LICENSE V.2.0. YOU MAY OBTAIN A COPY OF THE LICENSE AT https://www.apache.org/licenses/LICENSE-2.0.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

pkg/builder/in_memory_build_queue.go Outdated Show resolved Hide resolved
pkg/builder/output_hierarchy.go Outdated Show resolved Hide resolved
@mou-hao mou-hao marked this pull request as ready for review October 26, 2021 05:37
Copy link
Member

@EdSchouten EdSchouten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to seeing this land!

pkg/builder/output_hierarchy_test.go Outdated Show resolved Hide resolved
pkg/runner/local_runner_test.go Outdated Show resolved Hide resolved
pkg/runner/local_runner_test.go Outdated Show resolved Hide resolved
pkg/runner/local_runner_windows.go Outdated Show resolved Hide resolved
@mou-hao
Copy link
Contributor Author

mou-hao commented Oct 27, 2021

Should be good for another round of review. 😄

pkg/runner/local_runner.go Outdated Show resolved Hide resolved
pkg/runner/local_runner.go Outdated Show resolved Hide resolved
Copy link
Member

@EdSchouten EdSchouten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking perfect. Thanks for your perseverance!

I've re-enabled CI again. It may be the case it complains about some missing docstrings on newly added public APIs? If so, could you address those? Will merge this change once CI is happy.

@mou-hao
Copy link
Contributor Author

mou-hao commented Oct 29, 2021

Looking perfect. Thanks for your perseverance!

I've re-enabled CI again. It may be the case it complains about some missing docstrings on newly added public APIs? If so, could you address those? Will merge this change once CI is happy.

Done.

@EdSchouten EdSchouten merged commit 66ef22f into buildbarn:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants