Bytestream ephmeral links for downloading logs from the problems tab #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, we surface an error when. bytestream url is encountered during blob serialization. This PR adds a button to the output displayed on the problems tab for build and test errors.
While this solution is not perfect, it is at least a step towards a more complete implementation for handling bytestream data returned from a remote execution system for log output on errored steps. Long term, we want a configuration option to inline the logs and allow people to chose whether or not to save items to the disk so that they will exist beyond the lifespan of the cached data, but for now, i've added a download button that will give you the ability to pull the blob from the cache for at least as long as its there, similar to how the profile download button is implemented
for build and test errors, a download button is provided when a bytestream url is found that points to the existing bb-browser public frontend url
the button has a tool tip and a warning icon and danger color so that people are notified ahead of time that this link is at best ephemeral and not to be depended on long term,
also added another status to the noop archiver as it was throwing an error on serialization, and put a docker command for launching sqllite browser in a shell script in the tools folder so i don't forget it and thought others may find it useful if they wish to explore the sqllite database that backs the application.