Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytestream ephmeral links for downloading logs from the problems tab #56

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

trey-ivy
Copy link
Collaborator

@trey-ivy trey-ivy commented Nov 13, 2024

At present, we surface an error when. bytestream url is encountered during blob serialization. This PR adds a button to the output displayed on the problems tab for build and test errors.

While this solution is not perfect, it is at least a step towards a more complete implementation for handling bytestream data returned from a remote execution system for log output on errored steps. Long term, we want a configuration option to inline the logs and allow people to chose whether or not to save items to the disk so that they will exist beyond the lifespan of the cached data, but for now, i've added a download button that will give you the ability to pull the blob from the cache for at least as long as its there, similar to how the profile download button is implemented

for build and test errors, a download button is provided when a bytestream url is found that points to the existing bb-browser public frontend url

the button has a tool tip and a warning icon and danger color so that people are notified ahead of time that this link is at best ephemeral and not to be depended on long term,

image

also added another status to the noop archiver as it was throwing an error on serialization, and put a docker command for launching sqllite browser in a shell script in the tools folder so i don't forget it and thought others may find it useful if they wish to explore the sqllite database that backs the application.

@trey-ivy trey-ivy requested a review from mortenmj November 13, 2024 18:55
Copy link
Collaborator

@mortenmj mortenmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mortenmj mortenmj merged commit dc79608 into main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants