Relax checks on response status code #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we require a 200 status code for events and a 202 for sessions but there's no need to be so specific as any 2xx status indicates success Now we only warn on codes outside of the 2xx range, unless a specific code has been set in `options['success']`. If a specific code is given then it must match exactly, i.e. it has the same behaviour as before
tomlongridge
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently we require a 200 status code for events and a 202 for sessions but there's no need to be so specific as any 2xx status indicates success
Now we only warn on codes outside of the 2xx range, unless a specific code has been set in
options['success']. If a specific code is given then it must match exactly, i.e. it has the same behaviour as beforeThis generally shouldn't affect users as the event & session endpoints always respond with 200 & 202 but can prevent spurious warnings if delivering to a custom service that doesn't use the same codes (e.g. a forwarding agent)