Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled exceptions in lambdas being marked as handled #381

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix unhandled exceptions in lambdas being marked as handled #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bugsnag/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,12 @@ def report_timeout_to_bugsnag():
return real_handler(aws_event, aws_context)
except Exception as exception:
if self.configuration.auto_notify:
self.notify(exception)
self.notify(
exception,
unhandled=True,
severity='error',
severity_reason={'type': 'unhandledException'},
)

raise
finally:
Expand Down
2 changes: 2 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1843,6 +1843,7 @@ def my_handler(event, context):
payload = self.server.events_received[0]['json_body']
event = payload['events'][0]

assert event['unhandled']
assert event['exceptions'][0]['message'] == 'oh dear'
assert event['metaData']['AWS Lambda Event'] == {'a': 1}
assert event['metaData']['AWS Lambda Context'] == {
Expand Down Expand Up @@ -1878,6 +1879,7 @@ def my_handler(event, context):
payload = self.server.events_received[0]['json_body']
event = payload['events'][0]

assert event['unhandled']
assert event['exceptions'][0]['message'] == 'oh dear'
assert event['metaData']['AWS Lambda Event'] == {'z': 9}
assert event['metaData']['AWS Lambda Context'] == {
Expand Down
Loading