Add warning when lambda function may timeout #379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds a notify for lambda functions when they are likely to timeout — by default this happens 1 second before the timeout occurs but can be configured with the new
lambda_timeout_notify_ms
option:There's some complexity here because the notify happens off of the main thread so any thread-local data wouldn't be present in the event. In order to include all of the relevant information (e.g. metadata, breadcrumbs, feature flags) we need to manually copy it over into the timer thread