Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of URL constructor in test steps #2321

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Update usage of URL constructor in test steps #2321

merged 1 commit into from
Feb 12, 2025

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Feb 12, 2025 •
edited
Loading

Goal

Resolve code scanning issue:

Use of Kernel.open or IO.read or similar sinks with a non-constant value

@gingerbenw gingerbenw changed the title refactor: 🔒 Update usage of URI constructor Resolve update usage of URL constructor in tests Feb 12, 2025
@gingerbenw gingerbenw changed the title Resolve update usage of URL constructor in tests Resolve update usage of URL constructor in test steps Feb 12, 2025
@gingerbenw gingerbenw requested a review from Cawllec February 12, 2025 15:30
@gingerbenw gingerbenw marked this pull request as ready for review February 12, 2025 15:30
@gingerbenw gingerbenw changed the title Resolve update usage of URL constructor in test steps Update usage of URL constructor in test steps Feb 12, 2025
@gingerbenw gingerbenw merged commit 638a47c into next Feb 12, 2025
58 checks passed
@gingerbenw gingerbenw deleted the PLAT-12813/code-ql-uri branch February 12, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cawllec Cawllec Cawllec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbenw @Cawllec