Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node-fetch dependency #2281

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Remove node-fetch dependency #2281

merged 2 commits into from
Jan 27, 2025
+244 −110

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Jan 14, 2025 •
edited
Loading

Goal

Remove node-fetch to resolve CVE-2022-0235

Testing

Covered by existing tests

@djskinner
Copy link
Contributor

since fetch is part of node 18 we should be able to drop node-fetch entirely

@gingerbenw gingerbenw force-pushed the PLAT-10393/CVE-2022-0235 branch from c3b73b4 to ab673c0 Compare January 24, 2025 14:03
@github-actions GitHub Actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 45.89 kB 13.78 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against ab673c0

@gingerbenw gingerbenw changed the title Update node-fetch Remove node-fetch dependency Jan 24, 2025
@gingerbenw gingerbenw requested a review from djskinner January 24, 2025 20:59
@gingerbenw gingerbenw marked this pull request as ready for review January 24, 2025 21:00
@gingerbenw gingerbenw merged commit 71d3c93 into next Jan 27, 2025
59 checks passed
@gingerbenw gingerbenw deleted the PLAT-10393/CVE-2022-0235 branch January 27, 2025 17:44
hannah-smartbear pushed a commit that referenced this pull request Jan 31, 2025
@gingerbenw @hannah-smartbear
Remove node-fetch dependency (#2281)
3d68d6e 
* chore: 🔒 override node-fetch version

* chore: ➖ remove node-fetch dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gingerbenw @djskinner