Generate type definition using Angular 17 #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11f76f4 to
a039da2
Compare
a039da2 to
d7bd486
Compare
gingerbenw
commented
Dec 12, 2024
| @@ -57,7 +57,7 @@ import 'core-js/es7/reflect'; | |||
| /*************************************************************************************************** | |||
| * Zone JS is required by default for Angular itself. | |||
| */ | |||
| import 'zone.js/dist/zone'; // Included with Angular CLI. | |||
| import 'zone.js'; // Included with Angular CLI. | |||
2e7c4d9 to
c9990c8
Compare
ngDebugContext has been removed and was not reported in production
gingerbenw
commented
Dec 17, 2024
| @@ -9,4 +9,3 @@ Scenario: basic error handler usage | |||
| And the test should run in this browser | |||
| Then I wait to receive an error | |||
| And the error is a valid browser payload for the error reporting API | |||
| And the event "metaData.angular" is not null | |||
There was a problem hiding this comment.
Dropped as ngDebugContext is no longer present, and previously only worked in debug builds. Will raise a separate task to reintroduce similar metadata if available in ivy builds.
26eea00 to
02486a0
Compare
hannah-smartbear
pushed a commit
that referenced
this pull request
Jan 31, 2025
* chore(@bugnsnag/plugin-angular): ⬆️ update angular dependency to v17 * test: ✅ update browserslist for angular plugin fixture * chore: add .angular to gitignore * docs: 📝 update CHANGELOG * test: ✅ update skip logic * refactor: 🔥 remove debug context metadata ngDebugContext has been removed and was not reported in production * add globalthis polyfill * add queueMicrotask polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ensure
@bugsnag/plugin-angularworks with recent versions of angularDesign
Update dev dependency to v17 to ensure that generated types are compatible with Angular 17 (earliest supported version according to the angular documentation)
Changeset
Update Angular dependencies to v17
Remove code for dropped
ngDebugContextTesting
Update test fixture to v17 and test against full ci build